[GOBBLIN-825] Initialize message schema at object construction rather than creating a new instance for every message #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…espace in the constructor instead of creating a new schema each time before pushing the message
vikrambohra
changed the title
zxcware
suggested changes
Jul 15, 2019
| @@ -58,6 +60,7 @@ | |||
| protected KeyValuePusher pusher; | |||
| protected Optional<Map<String, String>> namespaceOverride; | |||
| protected final String topic; | |||
| @@ -58,6 +60,7 @@ | |||
| protected KeyValuePusher pusher; | |||
| protected Optional<Map<String, String>> namespaceOverride; | |||
zxcware
approved these changes
Jul 15, 2019
htran1
reviewed
Jul 15, 2019
|
|
||
| GenericRecord record=event; | ||
| try { | ||
| record = AvroUtils.convertRecordSchema(event, schema); |
There was a problem hiding this comment.
This conversion is expensive to do on every event. This is the same behavior as today, so it is not making things worse, but we should consider supporting pluggable compiled schemas to avoid the need to override the namespace.
There was a problem hiding this comment.
Its not on every event but every new instance of the reporter. So it's probably the order of mappers than number of messages sent out which is probably in the order of thousands.
jhsenjaliya
pushed a commit
to jhsenjaliya/incubator-gobblin
that referenced
this pull request
Apr 26, 2020
… than creating a new instance for every message Closes apache#2686 from vikrambohra/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
An issue with a schema registry client caused this issue. This issue fixes the creation of new instances of the same schema for every message sent. Instead we now create an instance of the schema during object construction and use the same schema instance for all the messages.
Tests
Commits