GOBBLIN-836: Expose container logs location via system property to be…

[sv2000]

… used in log4j configuration for Gobblin-on-Yarn applications

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

• My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
  • https://issues.apache.org/jira/browse/GOBBLIN-836
    Expose container logs location via system property to be used in log4j configuration for Gobblin-on-Yarn applications

Description

• Here are some details about my PR, including screenshots (if applicable):
  This task exposes container log directory and container log file name via Java System properties, so that they can be referenced in log4j properties. This in turn allows configuring log rotation of container logs based on size and maximum number of back ups.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:
  Tested by deploying a Gobblin-on-Yarn application

Commits

• My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

[htran1]

+1

[codecov-io]

Codecov Report

Merging #2694 into master will increase coverage by 0.04%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #2694      +/-   ##
============================================
+ Coverage     44.79%   44.84%   +0.04%     
- Complexity     8686     8691       +5     
============================================
  Files          1878     1878              
  Lines         70054    70058       +4     
  Branches       7701     7701              
============================================
+ Hits          31384    31417      +33     
+ Misses        35764    35738      -26     
+ Partials       2906     2903       -3

Impacted Files	Coverage Δ	Complexity Δ
...che/gobblin/yarn/GobblinYarnConfigurationKeys.java	0% <ø> (ø)	0 <0> (ø)	⬇️
...main/java/org/apache/gobblin/yarn/YarnService.java	14.64% <0%> (-0.09%)	3 <0> (ø)
...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java	19.89% <100%> (+0.42%)	7 <0> (ø)	⬇️
...lin/restli/throttling/ZookeeperLeaderElection.java	70% <0%> (-2.23%)	13% <0%> (ø)
...in/java/org/apache/gobblin/cluster/HelixUtils.java	41.83% <0%> (ø)	14% <0%> (+1%)	⬆️
.../org/apache/gobblin/cluster/GobblinTaskRunner.java	66.19% <0%> (+0.46%)	29% <0%> (ø)	⬇️
.../apache/gobblin/runtime/api/JobExecutionState.java	80.37% <0%> (+0.93%)	24% <0%> (ø)	⬇️
...ache/gobblin/cluster/GobblinHelixJobScheduler.java	40.52% <0%> (+1.3%)	6% <0%> (ø)	⬇️
...pache/gobblin/cluster/GobblinHelixJobLauncher.java	83.33% <0%> (+2.08%)	28% <0%> (+2%)	⬆️
.../gobblin/cluster/HelixRetriggeringJobCallable.java	63.88% <0%> (+3.47%)	9% <0%> (ø)	⬇️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a74579...8531366. Read the comment docs.