New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GOBBLIN-849] Connect to Oracle using service name, update metadata query #2705
base: master
Are you sure you want to change the base?
Conversation
…data query for OracleExtractor
Codecov Report
@@ Coverage Diff @@
## master #2705 +/- ##
============================================
- Coverage 44.9% 44.88% -0.02%
+ Complexity 8713 8709 -4
============================================
Files 1879 1879
Lines 70079 70083 +4
Branches 7703 7706 +3
============================================
- Hits 31466 31454 -12
- Misses 35702 35719 +17
+ Partials 2911 2910 -1
Continue to review full report at Codecov.
|
+1, LGTM |
String sid = this.workUnitState.contains(ConfigurationKeys.SOURCE_CONN_SID) ? this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_SID).trim() : ""; | ||
String serviceName = this.workUnitState.contains(ConfigurationKeys.SOURCE_CONN_SERVICE_NAME) ? this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_SERVICE_NAME).trim() : ""; | ||
String conn; | ||
if(sid != null && sid.length() > 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace with if (!Strings.isNullOrEmpty(sid)) ?
String serviceName = this.workUnitState.contains(ConfigurationKeys.SOURCE_CONN_SERVICE_NAME) ? this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_SERVICE_NAME).trim() : ""; | ||
String conn; | ||
if(sid != null && sid.length() > 0) | ||
conn = ":" + sid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace "conn" with "serviceString" or something more meaningful?
…data query for OracleExtractor
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Improvement: Enable connection to oracle using service name
Bug Fix: Update metadata fetch query in OracleExtractor which was failing when we provide owner and table_name in lower case through job config file.
Tests
Commits