Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-855] persist dag after addspec #2711

Closed
wants to merge 1 commit into from

Conversation

arjun4084346
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! @sv2000 please review

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    need to persist dag as soon as it is updated with the returned job future form addSpec()

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    trivial changes

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-io
Copy link

Codecov Report

Merging #2711 into master will increase coverage by 40.88%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2711       +/-   ##
=============================================
+ Coverage      4.15%   45.03%   +40.88%     
- Complexity      736     8727     +7991     
=============================================
  Files          1879     1879               
  Lines         70111    70112        +1     
  Branches       7701     7701               
=============================================
+ Hits           2912    31577    +28665     
+ Misses        66893    35614    -31279     
- Partials        306     2921     +2615
Impacted Files Coverage Δ Complexity Δ
...blin/service/modules/orchestration/DagManager.java 74.62% <100%> (+74.62%) 11 <0> (+11) ⬆️
...ata/management/copy/hive/HivePartitionFileSet.java 0.95% <0%> (+0.95%) 1% <0%> (+1%) ⬆️
...ain/java/org/apache/gobblin/runtime/TaskState.java 81.97% <0%> (+1.16%) 32% <0%> (ø) ⬇️
...pache/gobblin/runtime/GobblinMultiTaskAttempt.java 56.3% <0%> (+1.35%) 27% <0%> (+2%) ⬆️
...ava/org/apache/gobblin/runtime/MultiConverter.java 83.6% <0%> (+1.63%) 9% <0%> (+1%) ⬆️
...rg/apache/gobblin/runtime/FsDatasetStateStore.java 73.8% <0%> (+1.78%) 35% <0%> (+1%) ⬆️
...a/org/apache/gobblin/cluster/SingleTaskRunner.java 1.85% <0%> (+1.85%) 1% <0%> (+1%) ⬆️
.../java/org/apache/gobblin/runtime/TaskExecutor.java 45.05% <0%> (+2.19%) 9% <0%> (+1%) ⬆️
...rg/apache/gobblin/runtime/AbstractJobLauncher.java 58.33% <0%> (+3.33%) 31% <0%> (+5%) ⬆️
...apache/gobblin/source/jdbc/SqlServerExtractor.java 4.41% <0%> (+4.41%) 3% <0%> (+3%) ⬆️
... and 1075 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 778d05f...4e94d14. Read the comment docs.

Copy link
Contributor

@sv2000 sv2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

@asfgit asfgit closed this in d03abaf Aug 14, 2019
jhsenjaliya pushed a commit to jhsenjaliya/incubator-gobblin that referenced this pull request Apr 26, 2020
Closes apache#2711 from arjun4084346/persistdags
@arjun4084346 arjun4084346 deleted the persistdags branch June 2, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants