Security token encryption support in SFDC connector #2718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers like setting up transport factory.
Codecov Report
@@ Coverage Diff @@
## master #2718 +/- ##
============================================
+ Coverage 45.07% 45.08% +0.01%
- Complexity 8743 8744 +1
============================================
Files 1880 1880
Lines 70169 70170 +1
Branches 7700 7700
============================================
+ Hits 31627 31636 +9
+ Misses 35616 35611 -5
+ Partials 2926 2923 -3
Continue to review full report at Codecov.
|
htran1
suggested changes
Aug 20, 2019
| @@ -83,6 +83,10 @@ public HttpEntity getAuthentication() throws RestApiConnectionException { | |||
| String password = PasswordManager.getInstance(this.state) | |||
| .readPassword(this.state.getProp(ConfigurationKeys.SOURCE_CONN_PASSWORD)); | |||
| String securityToken = this.state.getProp(ConfigurationKeys.SOURCE_CONN_SECURITY_TOKEN); | |||
| if (this.state.getPropAsBoolean(ConfigurationKeys.SOURCE_CONN_DECRYPT_SECURITY_TOKEN, false)) { | |||
There was a problem hiding this comment.
Why have the option? The password manager will pass the password through if it is not encoded.
There was a problem hiding this comment.
Agreed it's not required. Fixed it.
…andle non encoded token.
jhsenjaliya
pushed a commit
to jhsenjaliya/incubator-gobblin
that referenced
this pull request
Apr 26, 2020
…connector Closes apache#2718 from mvachhani/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Security token encryption support in SFDC connector so as not to have security token as plain text. This change will decrypt the security token of the encrypt flag is set.
Tests
Commits