Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-887] Generialize UniversalKafkaSource to accept Extractor that not extending KafkaExtractor #2741

Closed
wants to merge 1 commit into from

Conversation

autumnust
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Copy link
Contributor

@sv2000 sv2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. LGTM.

@codecov-io
Copy link

Codecov Report

Merging #2741 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2741      +/-   ##
============================================
+ Coverage     45.18%   45.18%   +<.01%     
- Complexity     8803     8806       +3     
============================================
  Files          1889     1889              
  Lines         70595    70595              
  Branches       7746     7746              
============================================
+ Hits          31897    31900       +3     
+ Misses        35746    35745       -1     
+ Partials       2952     2950       -2
Impacted Files Coverage Δ Complexity Δ
.../extractor/extract/kafka/UniversalKafkaSource.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...lin/restli/throttling/ZookeeperLeaderElection.java 70% <0%> (-2.23%) 13% <0%> (ø)
...lin/elasticsearch/writer/FutureCallbackHolder.java 61.42% <0%> (-1.43%) 4% <0%> (ø)
.../org/apache/gobblin/cluster/GobblinTaskRunner.java 64.81% <0%> (+0.46%) 28% <0%> (ø) ⬇️
...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java 64.44% <0%> (+1.11%) 16% <0%> (+1%) ⬆️
...ava/org/apache/gobblin/fsm/FiniteStateMachine.java 76.51% <0%> (+3.03%) 21% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483d42c...f7a9f39. Read the comment docs.

@asfgit asfgit closed this in a1061e4 Sep 26, 2019
jhsenjaliya pushed a commit to jhsenjaliya/incubator-gobblin that referenced this pull request Apr 26, 2020
…at not extending KafkaExtractor

Closes apache#2741 from autumnust/KafkaExtractor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants