Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-889] Fix the FileContext wrong fsUri issue. #2743

Closed
wants to merge 1 commit into from

Conversation

yukuai518
Copy link
Contributor

@yukuai518 yukuai518 commented Sep 26, 2019

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    In FsDataWriter, the FileContext doesn't take the fsUri into account during the creation.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-io
Copy link

Codecov Report

Merging #2743 into master will increase coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2743      +/-   ##
============================================
+ Coverage     45.18%   45.18%   +<.01%     
  Complexity     8803     8803              
============================================
  Files          1889     1889              
  Lines         70595    70597       +2     
  Branches       7746     7746              
============================================
+ Hits          31897    31898       +1     
- Misses        35746    35749       +3     
+ Partials       2952     2950       -2
Impacted Files Coverage Δ Complexity Δ
...main/java/org/apache/gobblin/util/WriterUtils.java 38.52% <0%> (-0.32%) 15 <0> (ø)
...n/java/org/apache/gobblin/writer/FsDataWriter.java 69.72% <100%> (+0.28%) 15 <0> (ø) ⬇️
...in/java/org/apache/gobblin/cluster/HelixUtils.java 35.51% <0%> (-3.74%) 12% <0%> (-1%)
.../org/apache/gobblin/cluster/GobblinTaskRunner.java 65.27% <0%> (+0.92%) 28% <0%> (ø) ⬇️
.../apache/gobblin/runtime/api/JobExecutionState.java 80.37% <0%> (+0.93%) 24% <0%> (ø) ⬇️
...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java 64.44% <0%> (+1.11%) 16% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483d42c...92063d2. Read the comment docs.

@yukuai518
Copy link
Contributor Author

@htran1 can you help review?

Copy link
Contributor

@htran1 htran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in f24b5ea Sep 26, 2019
@yukuai518 yukuai518 changed the title [GOBBLIN-887] Fix the FileContext wrong fsUri issue. [GOBBLIN-889] Fix the FileContext wrong fsUri issue. Sep 26, 2019
jhsenjaliya pushed a commit to jhsenjaliya/incubator-gobblin that referenced this pull request Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants