[GOBBLIN-892] reverting back bad changes done in PR 2720

[arjun4084346]

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

• My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
  • https://issues.apache.org/jira/browse/GOBBLIN-892

Description

• Here are some details about my PR, including screenshots (if applicable):

fix a bug where we are setting/getting props in dataset state. it is not a supported operation.
This bug was introduced in #2720 (Jira GOBBLIN-864)

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:
  reverting back to older, more stable state

Commits

• My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

[codecov-io]

Codecov Report

Merging #2747 into master will increase coverage by 0.04%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #2747      +/-   ##
============================================
+ Coverage     45.19%   45.23%   +0.04%     
- Complexity     8804     8814      +10     
============================================
  Files          1889     1889              
  Lines         70581    70577       -4     
  Branches       7747     7747              
============================================
+ Hits          31899    31928      +29     
+ Misses        35729    35699      -30     
+ Partials       2953     2950       -3

Impacted Files	Coverage Δ	Complexity Δ
.../org/apache/gobblin/runtime/SafeDatasetCommit.java	47.31% <50%> (+7.6%)	29 <0> (+4)	⬆️
.../apache/gobblin/runtime/api/JobExecutionState.java	79.43% <0%> (-0.94%)	24% <0%> (ø)
...main/java/org/apache/gobblin/runtime/JobState.java	75.28% <0%> (-0.29%)	58% <0%> (ø)
.../org/apache/gobblin/cluster/GobblinTaskRunner.java	64.81% <0%> (+0.46%)	28% <0%> (ø)	⬇️
...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java	64.44% <0%> (+1.11%)	16% <0%> (+1%)	⬆️
...ain/java/org/apache/gobblin/runtime/TaskState.java	81.97% <0%> (+1.16%)	32% <0%> (ø)	⬇️
.../org/apache/gobblin/metrics/RootMetricContext.java	79.68% <0%> (+1.56%)	16% <0%> (+1%)	⬆️
...in/java/org/apache/gobblin/cluster/HelixUtils.java	39.25% <0%> (+3.73%)	13% <0%> (+1%)	⬆️
...a/management/copy/publisher/CopyDataPublisher.java	66.43% <0%> (+4.79%)	25% <0%> (+3%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc2b3a...0fa3354. Read the comment docs.

[zxcware]

Maybe keep this warning, it looks helpful.

[arjun4084346]

I am quite sure this warning must have got logged in the original-place-of-failure. What do you think?

[zxcware]

probably. If so, it's logged in some mapper node, which is hard to locate, which might be the reason that finalizeDatasetState do so.

[sv2000]

@arjun4084346 can you please add a description of what this PR is trying to address? Please describe what changes are being reverted. Can you also reference the JIRA ticket in the JIRA section?

[sv2000]

+1. LGTM.