Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gobblin-902] Enable gobblin yarn app luncher class configurable #2758

Closed
wants to merge 12 commits into from

Conversation

ZihanLi58
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    make gobblin yarn app launcher class to be configurable and reconstruct some code to make code reusable

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Run e2e test on azkaban

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@ZihanLi58
Copy link
Contributor Author

@sv2000 Can you take a look at this change? thx

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #2758 into master will increase coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2758      +/-   ##
============================================
+ Coverage     45.26%   45.27%   +<.01%     
- Complexity     8828     8831       +3     
============================================
  Files          1889     1889              
  Lines         70636    70645       +9     
  Branches       7757     7757              
============================================
+ Hits          31975    31986      +11     
+ Misses        35709    35706       -3     
- Partials       2952     2953       +1
Impacted Files Coverage Δ Complexity Δ
...org/apache/gobblin/yarn/GobblinYarnTaskRunner.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...gobblin/azkaban/AzkabanGobblinYarnAppLauncher.java 28.94% <0%> (-4.39%) 2 <0> (ø)
...rg/apache/gobblin/yarn/YarnAppSecurityManager.java 37.96% <100%> (+1.17%) 6 <1> (+1) ⬆️
...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java 20.31% <55.55%> (-0.11%) 7 <3> (ø)
.../apache/gobblin/runtime/api/JobExecutionState.java 79.43% <0%> (-0.94%) 24% <0%> (ø)
...main/java/org/apache/gobblin/util/HadoopUtils.java 30.87% <0%> (+0.67%) 25% <0%> (+1%) ⬆️
.../org/apache/gobblin/cluster/GobblinTaskRunner.java 64.81% <0%> (+0.92%) 28% <0%> (ø) ⬇️
...lin/restli/throttling/ZookeeperLeaderElection.java 72.22% <0%> (+2.22%) 13% <0%> (ø) ⬇️
...in/java/org/apache/gobblin/cluster/HelixUtils.java 39.25% <0%> (+3.73%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1446694...2c2028d. Read the comment docs.

Copy link
Contributor

@sv2000 sv2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If the code reformats are unintentional, can you please fix those? Since it is hard to know what really changed in the code.

Copy link
Contributor

@sv2000 sv2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. LGTM.

@asfgit asfgit closed this in bce5cbc Oct 11, 2019
jhsenjaliya pushed a commit to jhsenjaliya/incubator-gobblin that referenced this pull request Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants