New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gobblin-902] Enable gobblin yarn app luncher class configurable #2758
Conversation
…ble for the dataset
…e of embedded gobblin test
…ct some code to make it reusable
@sv2000 Can you take a look at this change? thx |
Codecov Report
@@ Coverage Diff @@
## master #2758 +/- ##
============================================
+ Coverage 45.26% 45.27% +<.01%
- Complexity 8828 8831 +3
============================================
Files 1889 1889
Lines 70636 70645 +9
Branches 7757 7757
============================================
+ Hits 31975 31986 +11
+ Misses 35709 35706 -3
- Partials 2952 2953 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If the code reformats are unintentional, can you please fix those? Since it is hard to know what really changed in the code.
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/CopySource.java
Outdated
Show resolved
Hide resolved
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
Outdated
Show resolved
Hide resolved
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
Outdated
Show resolved
Hide resolved
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
Outdated
Show resolved
Hide resolved
…tead of only when keytabe path is set
…urity manager be configurable and can be reimplemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. LGTM.
…igurable Closes apache#2758 from ZihanLi58/GOBBLIN-902
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
make gobblin yarn app launcher class to be configurable and reconstruct some code to make code reusable
Tests
Run e2e test on azkaban
Commits