-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GOBBLIN-915] Allow user customize the Extract timezone #2768
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2768 +/- ##
============================================
- Coverage 45.29% 44.33% -0.97%
+ Complexity 8848 8675 -173
============================================
Files 1892 1892
Lines 70750 70752 +2
Branches 7773 7773
============================================
- Hits 32048 31366 -682
- Misses 35743 36470 +727
+ Partials 2959 2916 -43
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
Just curious, changes in https://github.com/apache/incubator-gobblin/pull/2745/files change the Extract
constructor but seems it is not working as expected. Can you help me understand the reason briefly ?
@autumnust |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Closes apache#2768 from yukuai518/tmzone
Closes apache#2768 from yukuai518/tmzone
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Tests
Commits