Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-915] Allow user customize the Extract timezone #2768

Closed
wants to merge 1 commit into from

Conversation

yukuai518
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-io
Copy link

codecov-io commented Oct 17, 2019

Codecov Report

Merging #2768 into master will decrease coverage by 0.96%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2768      +/-   ##
============================================
- Coverage     45.29%   44.33%   -0.97%     
+ Complexity     8848     8675     -173     
============================================
  Files          1892     1892              
  Lines         70750    70752       +2     
  Branches       7773     7773              
============================================
- Hits          32048    31366     -682     
- Misses        35743    36470     +727     
+ Partials       2959     2916      -43
Impacted Files Coverage Δ Complexity Δ
...pache/gobblin/configuration/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...in/source/extractor/filebased/FileBasedSource.java 54.26% <100%> (+1.08%) 13 <0> (ø) ⬇️
...va/org/apache/gobblin/source/workunit/Extract.java 39.06% <100%> (-0.94%) 8 <1> (-2)
...re/filesystem/FsDatasetStateStoreEntryManager.java 0% <0%> (-100%) 0% <0%> (-3%)
...askStateCollectorServiceHiveRegHandlerFactory.java 0% <0%> (-100%) 0% <0%> (-2%)
...gobblin/runtime/mapreduce/GobblinOutputFormat.java 0% <0%> (-100%) 0% <0%> (-2%)
...in/runtime/mapreduce/CustomizedProgresserBase.java 0% <0%> (-83.34%) 0% <0%> (-1%)
...rg/apache/gobblin/runtime/ZkDatasetStateStore.java 0% <0%> (-80.77%) 0% <0%> (-7%)
...lin/runtime/locks/LegacyJobLockFactoryManager.java 0% <0%> (-78.58%) 0% <0%> (-2%)
...e/HiveRegTaskStateCollectorServiceHandlerImpl.java 0% <0%> (-75%) 0% <0%> (-3%)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21459db...a823c01. Read the comment docs.

Copy link
Contributor

@autumnust autumnust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

Just curious, changes in https://github.com/apache/incubator-gobblin/pull/2745/files change the Extract constructor but seems it is not working as expected. Can you help me understand the reason briefly ?

@yukuai518
Copy link
Contributor Author

@autumnust
Here is the original logic. You have an empty SourceState.
public Extract(TableType type, String namespace, String table) {
this(new SourceState(), type, namespace, table);
}

Copy link
Contributor

@htran1 htran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in b92f516 Oct 17, 2019
vikrambohra pushed a commit to vikrambohra/incubator-gobblin that referenced this pull request Oct 18, 2019
jhsenjaliya pushed a commit to jhsenjaliya/incubator-gobblin that referenced this pull request Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants