-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GOBBLIN-960]Resolving multiple templates in top-level #2809
Conversation
@jack-moseley @sv2000 Can you take a look once you have time? Thanks |
6a7c229
to
d82d9ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #2809 +/- ##
============================================
- Coverage 45.47% 44.52% -0.95%
+ Complexity 8909 8749 -160
============================================
Files 1899 1899
Lines 71098 71132 +34
Branches 7833 7846 +13
============================================
- Hits 32330 31671 -659
- Misses 35786 36522 +736
+ Partials 2982 2939 -43
Continue to review full report at Codecov.
|
if (newTemplate instanceof InheritingJobTemplate) { | ||
((InheritingJobTemplate) newTemplate).resolveTemplates(loadedTemplates); | ||
|
||
if (this.superTemplateUris.size() > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add some javadoc for resolveTemplates
method since this logic is a bit confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/template/InheritingJobTemplate.java
Show resolved
Hide resolved
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/template/StaticJobTemplate.java
Outdated
Show resolved
Hide resolved
… could be accessed externally
9fa6a54
to
2bca258
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. LGTM.
Closes apache#2809 from autumnust/multiple-templates
Closes apache#2809 from autumnust/multiple-templates
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
It contains some fixes on access-modifier of Avro2ORC while reading through code, but the major part is to enabled
gobblin.templates.uri
to be able to accept multiple templates.Tests
Commits