[GOBBLIN-1049] Move workunit commit logic to the end of publish().

[yukuai518]

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

• My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
  • https://issues.apache.org/jira/browse/GOBBLIN-1049

Description

• Here are some details about my PR, including screenshots (if applicable):
  Add the markCommit() in the DataPublisher interface, which is at the end of the publishing logic.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

[codecov-io]

Codecov Report

Merging #2889 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #2889      +/-   ##
============================================
- Coverage     45.72%   45.72%   -0.01%     
+ Complexity     9129     9128       -1     
============================================
  Files          1926     1926              
  Lines         72563    72566       +3     
  Branches       7993     7993              
============================================
  Hits          33180    33180              
- Misses        36348    36349       +1     
- Partials       3035     3037       +2

Impacted Files	Coverage Δ	Complexity Δ
...rg/apache/gobblin/publisher/BaseDataPublisher.java	67.74% <ø> (-0.31%)	61 <0> (-1)
...va/org/apache/gobblin/publisher/DataPublisher.java	0% <0%> (ø)	0 <0> (ø)	⬇️
.../org/apache/gobblin/metrics/RootMetricContext.java	78.12% <0%> (-1.57%)	15% <0%> (-1%)
...lin/elasticsearch/writer/FutureCallbackHolder.java	61.42% <0%> (-1.43%)	4% <0%> (ø)
.../org/apache/gobblin/cluster/GobblinTaskRunner.java	65.06% <0%> (+1.31%)	29% <0%> (+1%)	⬆️
...lin/restli/throttling/ZookeeperLeaderElection.java	72.22% <0%> (+2.22%)	13% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f5932...a0a899e. Read the comment docs.

[htran1]

+1