GOBBLIN-1107: Lazily initialize Helix TaskStateModelFactory in Gobbli… #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@autumnust please review. |
Codecov Report
@@ Coverage Diff @@
## master #2947 +/- ##
============================================
- Coverage 45.56% 44.64% -0.93%
+ Complexity 9153 8988 -165
============================================
Files 1936 1936
Lines 73292 73295 +3
Branches 8088 8088
============================================
- Hits 33395 32722 -673
- Misses 36800 37521 +721
+ Partials 3097 3052 -45 Continue to review full report at Codecov.
|
autumnust
requested changes
Apr 2, 2020
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java
Show resolved
Hide resolved
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java
Outdated
Show resolved
Hide resolved
gobblin-cluster/src/test/java/org/apache/gobblin/cluster/GobblinTaskRunnerTest.java
Outdated
Show resolved
Hide resolved
| @@ -156,13 +179,73 @@ public void testConnectHelixManagerWithRetry() { | |||
| //Ensure that connect with retry succeeds | |||
| corruptGobblinTaskRunner.connectHelixManagerWithRetry(); | |||
| Assert.assertTrue(true); | |||
|
|
|||
| corruptGobblinTaskRunner.disconnectHelixManager(); | |||
There was a problem hiding this comment.
Should corruptGobblinTaskRunner be a local variable?
gobblin-cluster/src/test/java/org/apache/gobblin/cluster/GobblinTaskRunnerTest.java
Show resolved
Hide resolved
autumnust
approved these changes
Apr 2, 2020
| /** | ||
| * A helper method that creates a partial instance structure in ZK. | ||
| */ | ||
| private static void createPartialInstanceStructure(HelixManager helixManager, String zkConnectString) { |
There was a problem hiding this comment.
Should this be moved into utils class newly created ?
|
+1 LGTM. |
autumnust
approved these changes
Apr 3, 2020
haojiliu
pushed a commit
to haojiliu/incubator-gobblin
that referenced
this pull request
Apr 9, 2020
Closes apache#2947 from sv2000/taskRunner
arekusuri
pushed a commit
to arekusuri/incubator-gobblin
that referenced
this pull request
May 18, 2020
Closes apache#2947 from sv2000/taskRunner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nTaskRunner
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Current behavior eagerly initializes the taskStateModelFactory inside the constructor. This causes Helix task assignment to be stuck when a Helix manager connection needs to be retried.
Tests
Existing unit tests.
Commits