Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOBBLIN-1122: Bump up helix-lib version #2962

Closed
wants to merge 1 commit into from
Closed

Conversation

sv2000
Copy link
Contributor

@sv2000 sv2000 commented Apr 21, 2020

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Bump up helix dependency version to 0.9.4.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Trivial change

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-io
Copy link

Codecov Report

Merging #2962 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2962      +/-   ##
============================================
- Coverage     45.64%   45.63%   -0.01%     
+ Complexity     9195     9194       -1     
============================================
  Files          1938     1938              
  Lines         73520    73520              
  Branches       8125     8125              
============================================
- Hits          33556    33553       -3     
- Misses        36842    36843       +1     
- Partials       3122     3124       +2     
Impacted Files Coverage Δ Complexity Δ
...e/gobblin/runtime/app/ServiceBasedAppLauncher.java 43.68% <0.00%> (-1.95%) 12.00% <0.00%> (ø%)
.../org/apache/gobblin/metrics/RootMetricContext.java 78.12% <0.00%> (-1.57%) 15.00% <0.00%> (-1.00%)
...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java 63.33% <0.00%> (-1.12%) 15.00% <0.00%> (-1.00%)
.../apache/gobblin/runtime/api/JobExecutionState.java 79.43% <0.00%> (-0.94%) 24.00% <0.00%> (ø%)
...lin/util/filesystem/FileSystemInstrumentation.java 92.85% <0.00%> (ø) 4.00% <0.00%> (+1.00%)
.../org/apache/gobblin/cluster/GobblinTaskRunner.java 67.91% <0.00%> (+0.37%) 33.00% <0.00%> (ø%)
...a/org/apache/gobblin/util/limiter/NoopLimiter.java 60.00% <0.00%> (+20.00%) 3.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a634b4...2cc56fa. Read the comment docs.

@asfgit asfgit closed this in c407e20 Apr 21, 2020
arekusuri pushed a commit to arekusuri/incubator-gobblin that referenced this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants