Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOBBLIN-1123: Report orchestration delay for Gobblin Service flows #2963

Closed
wants to merge 5 commits into from

Conversation

sv2000
Copy link
Contributor

@sv2000 sv2000 commented Apr 22, 2020

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Measure and report the delay in orchestrating a flow submitted to GaaS.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Verified metrics are emitted in a local deployment.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@sv2000
Copy link
Contributor Author

sv2000 commented Apr 22, 2020

@jack-moseley @arjun4084346 Please review.

Copy link
Contributor

@jack-moseley jack-moseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjun4084346
Copy link
Contributor

LGTM

@sv2000 sv2000 closed this Apr 22, 2020
@sv2000 sv2000 reopened this Apr 22, 2020
@sv2000 sv2000 closed this Apr 23, 2020
@sv2000 sv2000 reopened this Apr 23, 2020
@sv2000 sv2000 closed this Apr 23, 2020
@sv2000 sv2000 reopened this Apr 23, 2020
@asfgit asfgit closed this in a52e1a8 Apr 23, 2020
arekusuri pushed a commit to arekusuri/incubator-gobblin that referenced this pull request May 18, 2020
… for Gobblin Service flows

Closes apache#2963 from sv2000/gaasOrchestrationDelay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants