Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1220] Log improvement #2991

Closed
wants to merge 2 commits into from

Conversation

arjun4084346
Copy link
Contributor

@arjun4084346 arjun4084346 commented May 19, 2020

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
@yukuai518 please review

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    a) this pr fixes some minor typos, whose impact might not be very ignorable.
    b) add toString GaaS Node class to improve log
    c) reduce helix job initialization time from Long.MAX_VAL to 5 minutes
    d) increase time between two helix job status checks from 1 second to 10 seconds to reduce logs

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    trivial changes

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@arjun4084346 arjun4084346 force-pushed the logImprovement branch 3 times, most recently from 3a4fd09 to ed9648e Compare July 22, 2020 01:24
@arjun4084346 arjun4084346 changed the title Log improvement [GOBBLIN-1220] Log improvement Jul 22, 2020
improve logging
@@ -122,8 +122,7 @@ public static void submitJobToQueue(
static void waitJobInitialization(
HelixManager helixManager,
String workFlowName,
String jobName,
long timeoutMillis) throws Exception {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was being called only from two places, with fix value in both the places , one is "300_000" (which has a typo), other is Long.MAX_VALUE, which doesn't make sense. I think we should not try that much for a helix job to initialize. I have fixed it to 5 minutes.

@asfgit asfgit closed this in f30e6f4 Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants