Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1176] create gobblin-all module resolving full dependency tree #3021

Closed
wants to merge 3 commits into from

Conversation

vikrambohra
Copy link
Contributor

@vikrambohra vikrambohra commented Jun 2, 2020

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2020

Codecov Report

Merging #3021 into master will increase coverage by 0.09%.
The diff coverage is 61.34%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3021      +/-   ##
============================================
+ Coverage     45.63%   45.73%   +0.09%     
- Complexity     9230     9293      +63     
============================================
  Files          1947     1951       +4     
  Lines         73968    74222     +254     
  Branches       8180     8213      +33     
============================================
+ Hits          33757    33943     +186     
- Misses        37049    37105      +56     
- Partials       3162     3174      +12     
Impacted Files Coverage Δ Complexity Δ
...gobblin/cluster/ContainerHealthCheckException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...bblin/cluster/GobblinClusterConfigurationKeys.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...gobblin/cluster/HelixAssignedParticipantCheck.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ache/gobblin/compaction/mapreduce/MRCompactor.java 7.14% <0.00%> (+0.09%) 9.00 <0.00> (ø)
.../couchbase/writer/CouchbaseEnvironmentFactory.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...he/gobblin/metrics/kafka/KafkaReporterFactory.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/source/extractor/extract/kafka/KafkaSource.java 1.34% <0.00%> (-0.01%) 1.00 <0.00> (ø)
...obblin/service/FlowConfigResourceLocalHandler.java 15.84% <0.00%> (+2.16%) 2.00 <0.00> (ø)
...rg/apache/gobblin/runtime/AbstractJobLauncher.java 60.36% <ø> (ø) 37.00 <0.00> (ø)
...n/runtime/job_exec/JobLauncherExecutionDriver.java 66.66% <ø> (ø) 14.00 <0.00> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad2da14...434a6e1. Read the comment docs.

Copy link
Contributor

@htran1 htran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in e9f35a8 Jun 2, 2020
@jhsenjaliya
Copy link
Contributor

Hi @vikrambohra, not sure about the context here. but can this be done with gobblin-flavor as well ? as I was thinking about this earlier. would be good to know. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants