Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1181] Make parquet-proto compileOnly dependency #3028

Closed
wants to merge 1 commit into from

Conversation

vikrambohra
Copy link
Contributor

@vikrambohra vikrambohra commented Jun 4, 2020

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    'org.apache.parquet:parquet-protobuf:1.10.1' is not resolvable from MavenCentral because it's missing some of its transitive dependencies. This will cause 'gobblin-apache-parquet' module also not be resolvable from Central (in the future, when it will be published to Central). To fix this, I suggest using 'compileOnly'. This will ensure that 'gobblin-parquet-apache' is cleanly resolvable from Central.

This change unblocks automated consumption of gobblin external artifact at LinkedIn

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Tested by running the build and inspecting the pom files

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Copy link
Contributor

@htran1 htran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@vikrambohra vikrambohra closed this Jun 4, 2020
@vikrambohra vikrambohra reopened this Jun 4, 2020
@vikrambohra vikrambohra closed this Jun 4, 2020
@vikrambohra vikrambohra reopened this Jun 4, 2020
@asfgit asfgit closed this in 3b82da5 Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants