Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HDP #409

Closed
wants to merge 2 commits into from
Closed

Conversation

SparshSinghalHM
Copy link
Contributor

Added parameter for CISF protection in Ambari. Can be provided in a separate branch.

Added parameter for CISF protection in Ambari.
String.class);
HttpHeaders headers = new HttpHeaders();
headers.setContentType(MediaType.APPLICATION_JSON);
headers.set("X-Requested-By","admin");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use a constant for the "X-Requested-By"?
public static final String REQUEST_BY_HEADER = "X-Requested-By";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Can do it this way.

@bhlx3lyx7
Copy link
Contributor

I've tested the code, it works in docker.
"X-Requested-By" could be set as any value, is it appropriate to hardcode it as "admin"?

@SparshSinghalHM
Copy link
Contributor Author

@bhlx3lyx7 No, not required. We can ask for the ambari username in application.properties. Admin is the default user.

@asfgit asfgit closed this in 33fe4c1 Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants