GRIFFIN-197 Treat non-existing YARN app as FAILED #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids jobs becoming stuck in UNKNOWN state on Service side. Also, improves logging for YARN client errors.
guoyuepeng
reviewed
Sep 22, 2018
| e.getMessage(), e.getResponseBodyAsString()); | ||
| if (e.getStatusCode() == HttpStatus.NOT_FOUND) { | ||
| // in sync with Livy behavior, see com.cloudera.livy.utils.SparkYarnApp | ||
| instance.setState(DEAD); |
There was a problem hiding this comment.
Agree we need to handle state,
but what if this is caused by network issue,
should we double confirm before we jump to conclusion that the instance is dead?
There was a problem hiding this comment.
Only 404 is handled here, which should not be result of network issue.
It looks like any kind of error reported by Yarn client (after internal retries) results in DEADing job on Livy side: https://github.com/cloudera/livy/blob/master/server/src/main/scala/com/cloudera/livy/utils/SparkYarnApp.scala#L307
I'll need to double check whether not found applications are ever getting retried, to make sure behavior is same as on Livy side. If not -- then that's what Livy would do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids jobs becoming stuck in UNKNOWN state on Service side.
Also, improves logging for YARN client errors.