[GRIFFIN-203] "Plaintext mode" for measure creation #446
Conversation
Created json/yaml measure creation flow Added ability to view measure as yaml
| if (response.code === '40901') { | ||
| this.toasterService.pop("error", "Error!", "Measure name already exists!"); | ||
| } else { | ||
| this.toasterService.pop("error", "Error!", "Measure is not valid"); |
There was a problem hiding this comment.
AFAIK response typically contains valid error message that can be shown
there was similar issue in other place: https://github.com/apache/incubator-griffin/pull/423/files
| } | ||
| } | ||
|
|
||
| options: ITreeOptions = { |
There was a problem hiding this comment.
you don't have any tree component here, so this does not seem to be needed
| <div class="modal fade" id="confirm" role="dialog" #modal tabindex="-1" [ngClass]="{'in': visibleAnimate}" | ||
| [ngStyle]="{'display': visible ? 'block' : 'none', 'opacity': visibleAnimate ? 1 : 0}" | ||
| (click)="onContainerClicked($event)"> | ||
| <div class="modal-dialog modal-xg modal-lg"> |
There was a problem hiding this comment.
this dialog looked not centered on screen record -- is that true or it's just me?
can you make it appear on center of the screen?
There was a problem hiding this comment.
I just didn't captured whole window, I've just checked and it's centered.
gavlyukovskiy
force-pushed
the
raw-measures
branch
from
e07a7e1
to
209b40f
Compare
| ); | ||
| } | ||
|
|
||
| onInputChange() { |
There was a problem hiding this comment.
how frequently is it triggered? on every key press, or there is some throttle?
is parsing delay noticeable while typing?
There was a problem hiding this comment.
As I can see it's done on every change, but is not noticeable on my laptop. Not sure if it will affect others, but anyway it's much easier to edit measure in normal editor and just copy-past it here :)
|
LGTM |
|
Awesome! |
|
Looks like there are still some rendering issues: |
|
Awesome feature! |
|
Thank you everyone for feedback, I'm not UI guy so structure was messed little bit :) I changed it to be consistent with other pages and now it looks much better. |
|
Great work, it works fine |
Created json/yaml measure creation flow:
Added ability to view measure as yaml:
I did not add any input validation, for now only server side validation is working. I'm not quite sure if copying validation from service side is a good choice.