Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAWQ-1195. Fixed error "Two or more external tables use the same erro… #1040

Merged
merged 1 commit into from Dec 14, 2016

Conversation

liming01
Copy link
Contributor

@liming01 liming01 commented Dec 6, 2016

…r table "

The error table should be works same as normal user table on hdfs, which support multiple INSERTs.

Hi @wangzw, could you help me to review it? Thanks.

@wengyanqing
Copy link
Contributor

LGTM

@huor
Copy link
Contributor

huor commented Dec 9, 2016

+1

@liming01 liming01 closed this Dec 12, 2016
@liming01 liming01 reopened this Dec 12, 2016
@liming01
Copy link
Contributor Author

Revert this commit because running installcheck-good failed.
It is my fault, I had thought that we have move all testcases in installcheck-good to featuretest, so I only ran feature test.

Need more time to investigate why it conflict at the same relation file number.

In this case, we should assign a new sets of seg files for INSERT INTO ERROR TABLE.
@liming01
Copy link
Contributor Author

When we found the same error table used for the same query, we should assign a new sets of seg files for INSERT INTO ERROR TABLE, which means different relation will insert into the different sets of segfiles.

@asfgit asfgit merged commit 6c295d0 into apache:master Dec 14, 2016
@wangzw
Copy link
Contributor

wangzw commented Dec 14, 2016

Hi guys, please see the comments in the JIRA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants