HAWQ-1409. Send AGG-TYPE header to PXF #1189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is mean to be a proof of concept that pushing down aggregate function information from HAWQ to the underlying external storage layer does indeed improve performance
shivzone
approved these changes
Mar 24, 2017
hsyuan
reviewed
Mar 25, 2017
| @@ -110,6 +110,20 @@ void build_http_header(PxfInputData *input) | |||
| else | |||
| churl_headers_append(headers, "X-GP-HAS-FILTER", "0"); | |||
|
|
|||
| /* Aggregate information */ | |||
| if (input->agg_type) { | |||
| char agg_groups_str[sizeof(int32)]; | |||
hsyuan
reviewed
Mar 25, 2017
src/backend/executor/nodeAgg.c
Outdated
| AggrefExprState *aggrefstate = (AggrefExprState *) lfirst(l); | ||
| Aggref *aggref = (Aggref *) aggrefstate->xprstate.expr; | ||
| //Only dealing with one agg | ||
| if (aggref->aggfnoid == 2147 || aggref->aggfnoid == 2803) { |
There was a problem hiding this comment.
Would be better use COUNT_ANY_OID and COUNT_STAR_OID...
hsyuan
reviewed
Mar 25, 2017
src/backend/access/external/fileam.c
Outdated
| * If we have an agg type then our parent is an Agg node | ||
| */ | ||
| rootPlan = state->state->es_plannedstmt->planTree; | ||
| if (rootPlan->type == T_Agg && es_state->parent_agg_type) { |
There was a problem hiding this comment.
Recommend to use IsA(rootPlan, Agg)
hsyuan
reviewed
Mar 25, 2017
src/backend/executor/nodeAgg.c
Outdated
| @@ -1950,6 +1950,21 @@ ExecInitAgg(Agg *node, EState *estate, int eflags) | |||
| * initialize child nodes | |||
| */ | |||
| outerPlan = outerPlan(node); | |||
| if (outerPlan->type == T_ExternalScan) { | |||
There was a problem hiding this comment.
Better use IsA(outerPlan, ExternalScan)
hsyuan
reviewed
Mar 25, 2017
src/backend/executor/nodeAgg.c
Outdated
| /* | ||
| * Hack to indicate to PXF when there is an external scan | ||
| */ | ||
| if (aggstate->aggs && list_length(aggstate->aggs) == 1) { |
There was a problem hiding this comment.
Do we need check aggstate->aggs is null or not? if it is null, list_length will return 0.
There was a problem hiding this comment.
Oh ok, I thought list_length() on a null value would cause an error
hsyuan
reviewed
Mar 25, 2017
src/backend/executor/nodeAgg.c
Outdated
| * Hack to indicate to PXF when there is an external scan | ||
| */ | ||
| if (aggstate->aggs && list_length(aggstate->aggs) == 1) { | ||
| foreach(l, aggstate->aggs) { |
There was a problem hiding this comment.
if the size of aggstate->aggs is already 1, do we need use foreach to iterate?
hsyuan
reviewed
Mar 25, 2017
src/backend/executor/nodeAgg.c
Outdated
| */ | ||
| if (aggstate->aggs && list_length(aggstate->aggs) == 1) { | ||
| foreach(l, aggstate->aggs) { | ||
| AggrefExprState *aggrefstate = (AggrefExprState *) lfirst(l); |
There was a problem hiding this comment.
just by changing lfirst(l) to linitial(aggstate->aggs), you can remove foreach loop.
avocader
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is mean to be a proof of concept that pushing down
aggregate function information from HAWQ to the underlying external
storage layer does indeed improve performance