HAWQ-1485. Fix exception of decryptPassword twice in lookupResource() #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interma
commented
Jun 15, 2017
| @@ -112,7 +119,7 @@ private void decryptPassword(Map<String, String> configs) throws Exception { | |||
| // when decrypt failed do nothing | |||
| LOG.warn("decrypt_password failed: " + e); | |||
| } | |||
| configs.put("password", normal_password); | |||
| configs.put("password_jdbc", normal_password); | |||
There was a problem hiding this comment.
put the decrypted password into a new field, so it doesn't influence the BaseClient decrypt it(the password field) again.
|
@linwen @zhangh43 @stanlyxiang help to review again, thanks! |
interma
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my earlier PR, decryptPassword() is called in the beginning of lookupResource(), but BaseClient (in ranger lib) also need decrypt password in some situation, decrypt twice will cause a exception.
This PR fixed this issue.