HAWQ-1607. This commit implements applying Bloom filter during Scan outer table #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 6, 2018 21:19
…uter table, test cases will be added with HAWQ-1608.
1. Pash down Bloom filter structure to outer table scan(only support parquet);
2. Check if the tuple from outer table is found in Bloom filter structure.
3. Add a GUC hawq_hashjoin_bloomfilter_sampling_number. This guc value controls the Bloom filter sampling number, while scanning outer table, for first N tuples of the outer table, if the ratio is larger than hawq_hashjoin_bloomfilter_ratio, the remain tuples will not be checked by Bloom filter.
4. If there is any expression on outer join keys except T_Var(projection), such as, fact.c1 + 1 = dim.c1. 2, if there are multiple join keys, e.g. fact.c1 = dim.c1 and fact.c2 = dim.c2, Bloomfilter won't be created. Since these cases invloves pushing down expression and project information to scan, which will be implemented later.
wengyanqing
reviewed
May 7, 2018
src/include/nodes/execnodes.h
Outdated
| @@ -1522,6 +1540,9 @@ typedef struct ScanState | |||
| /* The type of the table that is being scanned */ | |||
| TableType tableType; | |||
|
|
|||
| /* Runtime filter */ | |||
| struct RuntimeFilterState runtimeFilter; | |||
There was a problem hiding this comment.
Since ScanState need to be copied some times, it's better to use a point of RuntimeFilterState in the struct and allocate memory dynamically.
src/backend/executor/nodeHashjoin.c
Outdated
| memcpy(rf->hashfunctions, hjstate->hj_HashTable->hashfunctions, i*sizeof(FmgrInfo)); | ||
| size_t size = offsetof(BloomFilterData, data) + hjstate->hj_HashTable->bloomfilter->data_size; | ||
| rf->bloomfilter = palloc0(size); | ||
| memcpy(rf->bloomfilter, hjstate->hj_HashTable->bloomfilter, size); |
There was a problem hiding this comment.
Why not just assign hjstate->hj_HashTable->bloomfilter to rf->bloomfilter ?
src/backend/cdb/cdbparquetrowgroup.c
Outdated
|
|
||
| if(hawqAttrToParquetColNum[i] == 1) | ||
| int colReaderIndex = 0; | ||
| int16 proj[128]; |
There was a problem hiding this comment.
It's better to use natts instead of 128.
added 2 commits
May 7, 2018 17:52
|
merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2. Check if the tuple from outer table is found in Bloom filter structure.
3. Add a GUC hawq_hashjoin_bloomfilter_sampling_number. This guc value controls the Bloom filter sampling number, while scanning outer table, for first N tuples of the outer table, if the ratio is larger than hawq_hashjoin_bloomfilter_ratio, the remain tuples will not be checked by Bloom filter.
4. If there is any expression on outer join keys except T_Var(projection), such as, fact.c1 + 1 = dim.c1. 2, if there are multiple join keys, e.g. fact.c1 = dim.c1 and fact.c2 = dim.c2, Bloomfilter won't be created. Since these cases invloves pushing down expression and project information to scan, which will be implemented later.
Please review, thanks!