HAWQ-274. Add check for segments' temporary directories #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 17, 2016 18:46
1. add two columns in gp_segment_config, failed_tmpdir_num and failed_tmpdir; 2. segments' temporary directory information is loaded in shared memeory; 2. segment's RM process checks and reports failed tmp dir number and path in IMAlive message; 3. master's RM process updates segment's status in catalog table, if failed tmp dir number exceeds the guc values, this segment is considered as down.
|
The implementation looks good to me. +1 |
|
+1 |
| @@ -151,6 +152,7 @@ int initializeSocketServer_RMSEG(void) | |||
| } | |||
| #define SEGMENT_HEARTBEAT_INTERVAL (3LL * 1000000LL) | |||
| #define SEGMENT_HOSTCHECK_INTERVAL (5LL * 1000000LL) | |||
| #define SEGMENT_TMPDIRCHECK_INTERVAL (10 * 60LL * 1000000LL) | |||
There was a problem hiding this comment.
using three gucs for these three parameters might be better. It will make future tuning and testing work much easier.
There was a problem hiding this comment.
10mins looks a very long time too.
|
This PR has now been open for over 30 days. I see that HAWQ-274 was marked as resolved, did you simply forget to close the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the guc values, this segment is considered as down.
Please review, Thanks!