HAWQ-927. Pass ProjectionInfo data to PXF #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -158,6 +165,29 @@ static void add_tuple_desc_httpheader(CHURL_HEADERS headers, Relation rel) | |||
| pfree(formatter.data); | |||
| } | |||
|
|
|||
| static void add_projection_desc_httpheader(CHURL_HEADERS headers, ProjectionInfo *projInfo) { | |||
| int i; | |||
| char long_number[32]; | |||
There was a problem hiding this comment.
Since we are converting list_length(projInfo->pi_targetlist), we need an array thats 32 chars long to match the bit length of int.
There was a problem hiding this comment.
You can try something like:
char long_number[(sizeof int) * 8];
|
Please review @xunzhang @paul-guo- @huor |
|
I don't think u need more than 10 bytes for long_number to store a long int. |
| external_getnext_init(PlanState *state) { | ||
| ExternalSelectDesc desc = (ExternalSelectDesc) palloc0(sizeof(ExternalSelectDescData)); | ||
| if (state != NULL && state->ps_ProjInfo != NULL) { | ||
| desc->projInfo = state->ps_ProjInfo; |
There was a problem hiding this comment.
Second condition is redundant
|
LGTM. Remember rebasing the commits before checking in. 🍺 |
This commit makes the necessary modifications to the HAWQ side of the codebase to add a list of indices of projected columns
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the necessary modifications to the HAWQ side of
the codebase to add a list of indices of projected columns