Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAWQ-938. Remove ivy.xml in gpopt and read orca version from header file #806

Closed
wants to merge 1 commit into from
Closed

Conversation

hsyuan
Copy link
Member

@hsyuan hsyuan commented Jul 20, 2016

The old mechanism extracted the version numbers from the Ivy config file,
which doesn't do the right thing if you build without Ivy. Using the
version headers is simpler, anyway. Also removed ivy.xml and ivy-build.xml
under gpopt folder.

The old mechanism extracted the version numbers from the Ivy config file,
which doesn't do the right thing if you build without Ivy. Using the
version headers is simpler, anyway.
@hsyuan
Copy link
Member Author

hsyuan commented Jul 20, 2016

@changleicn @yaoj2 @wengyanqing
Please take a look.

@changleicn
Copy link
Contributor

@paul-guo- to review.

@paul-guo-
Copy link
Contributor

+1

By the way, I just noticed the following code in gpopt.mk

UNAME = $(shell uname)
UNAME_P = $(shell uname -p)
UNAME_M = $(shell uname -m)
ARCH_OS = GPOS_$(UNAME)
ARCH_CPU = GPOS_$(UNAME_P)

ifeq (Darwin, $(UNAME))
LDSFX = dylib
else
LDSFX = so
endif

Please use DLSUFFIX and PORTNAME which are defined in src/Makefile.global
(and its including makefiles),
and are generated with the configure command. This is another issue, you
could make the change in the future.

2016-07-21 9:21 GMT+08:00 Lei Chang notifications@github.com:

@paul-guo- https://github.com/paul-guo- to review.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#806 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHI5jOKt5ZuX3Q9Uo8NPkj8pX0HtdN4Dks5qXsmegaJpZM4JRNbc
.

@hsyuan
Copy link
Member Author

hsyuan commented Jul 21, 2016

Thanks, will take care of it and open another pull request in the future.

@hsyuan
Copy link
Member Author

hsyuan commented Aug 1, 2016

pushed to master:
78c2766

@hsyuan hsyuan closed this Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants