HAWQ-1131. Fix error message difference between Orca and Planner #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In ORCA, due to the way exception handled previously we do warning first and then later print error referring that message. In this commit, we enhanced the exception handling so we just print a single error message. - Removed 'PQO unable to generate a plan' or 'Aborting PQO plan generation' message and make the error message as close as the planner. - Updated error message with filename and line number from where the exception is raised. - Updated regression test expected output files Patches are ported the following commits from GPDB: greenplum-db/gpdb@4eb5db7 greenplum-db/gpdb@d41ebde Author: Karthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>
gporca has a set of banned API calls which needs to be allowed with the ALLOW_xxx macro in order for gpopt to compile. But it should be the library caller (HAWQ)'s responsibility to take care of the function call.
Closed
…d by GPORCA upgradation." This reverts commit d641f36.
|
+1 |
1 similar comment
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and then later print error referring that message. In this commit, we
enhanced the exception handling so we just print a single error message.
generation' message and make the error message as close as the planner.
is raised.
Patches are ported the following commits from GPDB:
greenplum-db/gpdb@4eb5db7
greenplum-db/gpdb@d41ebde
Author: Karthikeyan Jambu Rajaraman karthi.jrk@gmail.com