Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOP-3228, HOP-3252, HOP-3253 #1038

Merged
merged 3 commits into from Sep 6, 2021
Merged

HOP-3228, HOP-3252, HOP-3253 #1038

merged 3 commits into from Sep 6, 2021

Conversation

mattcasters
Copy link
Contributor

Small but important fixes

@hansva hansva merged commit a81c8f9 into apache:master Sep 6, 2021
jballment
jballment reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@jballment jballment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this solution posts all variable as parameters rather than parsing the actual parameters. While it may work, there may be unforeseen consequences of mixing the parameters and variables in this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jballment jballment jballment left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattcasters @jballment @hansva