Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CI #3

Closed
ShiKaiWi opened this issue Jul 18, 2022 · 4 comments · Fixed by #4
Closed

Support CI #3

ShiKaiWi opened this issue Jul 18, 2022 · 4 comments · Fixed by #4
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ShiKaiWi
Copy link
Member

Thie project needs CI based on Github Actions to ensure the quality of development. And now about the CI what I can come up with is these jobs:

And as for unit tests, now no unit test in this project has been provided and the test framework of the python project has not been decided yet so I suggest skipping the UT part in the CI for now.

@ShiKaiWi
Copy link
Member Author

ShiKaiWi commented Jul 18, 2022

@messense Would you like to take this task? And feel free to talk with us here or on slack if anything is unclear.

@ShiKaiWi ShiKaiWi added enhancement New feature or request help wanted Extra attention is needed labels Jul 18, 2022
@messense
Copy link
Member

Adding style checks are easy. I was thinking more about adding CI to build Python wheels, I can do this along the way.

I do think the dependency issue I mentioned should be addressed first, otherwise CI could be terribly slow.

@waynexia
Copy link
Member

That all-in-one dependent delegate brings lots of unnecessary deps to other crates like this client. I've suffered from it already 😷

@waynexia
Copy link
Member

Opened apache/horaedb#103 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants