Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cmake cross compiling fix for arm64 macOS #21

Merged
merged 1 commit into from
Aug 5, 2022
Merged

fix: cmake cross compiling fix for arm64 macOS #21

merged 1 commit into from
Aug 5, 2022

Conversation

messense
Copy link
Member

@messense messense commented Jul 29, 2022 •
edited
Loading

Fixes #20

@messense messense marked this pull request as draft July 29, 2022 02:50
@messense messense mentioned this pull request Jul 29, 2022
Closed
@ShiKaiWi
Copy link
Member

ShiKaiWi commented Aug 3, 2022

@messense All the checks pass already except that style check reports error: license check failed.

@messense messense marked this pull request as ready for review August 4, 2022 02:04
@messense messense changed the title Test cmake cross compiling fix fix: cmake cross compiling fix for arm64 macOS Aug 4, 2022
@waynexia waynexia requested a review from ShiKaiWi August 4, 2022 06:05
ShiKaiWi
ShiKaiWi approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@messense Thanks a lot for fixing such a tough issue.

@ShiKaiWi ShiKaiWi merged commit 5a63f4e into apache:main Aug 5, 2022
@messense messense deleted the cmake branch August 5, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arm64 macOS wheel is broken
2 participants
@messense @ShiKaiWi