refactor: switch to upstream object_store interface #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
4 tasks
4 tasks
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
waynexia
changed the title
waynexia
commented
Jun 2, 2022
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
ShiKaiWi
reviewed
Jun 2, 2022
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This was referenced Oct 18, 2022
Closed
chunshao90
referenced
this pull request
in chunshao90/ceresdb
May 15, 2023
* refactor: switch to upstream object_store Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * migrate benchmark suit Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * remove hard fork Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * remove unwrap of create_dir_all Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * style: run cargo fmt Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * chore: add todo and fix style Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * fix benchmark compile error Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Ref #13
Closed #15
Rationale for this change
The
object_storecomponent and related interfaces were forked from https://github.com/influxdata/influxdb_iox/tree/main/object_storeNow the upstream has separated it into a standalone crate and evolved more feather-rich and ergonomic interfaces. It would be better to migrate to it.
What changes are included in this PR?
Remove the hard fork of
object_store, and use a wrapper over docs.rs/object_store instead.Are there any user-facing changes?
no
How does this change test
UT