Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExternalSpillableMap should set all member variables (including newLocation and oldLocation) #418

Closed
n3nash opened this issue Jul 12, 2018 · 1 comment

Comments

@n3nash
Copy link
Contributor

n3nash commented Jul 12, 2018

The spillable map at the moment spills the HoodieRecord to disk. After it spills the record to disk, when recreating the record, it sets the hoodieKey and data back to the HoodieRecord, the constructor for HoodieRecord sets the newLocation and oldLocation to null as opposed to the actual value that was set during the index tagging process.
Since BloomIndex does not do any post operations with these fields, this issue was not seen there, but for HbaseIndex, the updateIndex() actually looks at these location variables and updates Hbase.

@n3nash n3nash added the bug label Jul 17, 2018
@n3nash
Copy link
Contributor Author

n3nash commented Jul 24, 2018

Fixed as part of #419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant