-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-503] Add hudi test suite documentation into the README file of the test suite module #1191
Conversation
cc @n3nash |
--class org.apache.hudi.bench.job.HudiTestSuiteJob | ||
--workload-yaml-path /path/to/your-workflow-dag.yaml | ||
... | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generating a custom Workload Pattern
There are 2 ways to generate a workload pattern:
- Programatically
Choose to write up the entire DAG of operations programatically, take a look atWorkflowDagGenerator
class. Once you're ready with the DAG you want to execute, simply pass the class name as follows:
spark-submit
...
...
--class org.apache.hudi.bench.job.HudiTestSuiteJob
--workload-generator-classname org.apache.hudi.bench.dag.scheduler.<your_workflowdaggenerator>
...
- YAML file
Choose to write up the entire DAG of operations in YAML, take a look atcomplex-workload-dag-cow.yaml
orcomplex-workload-dag-mor.yaml
. Once you're ready with the DAG you want to execute, simply pass the yaml file path as follows:
spark-submit
...
...
--class org.apache.hudi.bench.job.HudiTestSuiteJob
--workload-yaml-path /path/to/your-workflow-dag.yaml
...
Hey, I think it looks a little clearer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion. I have addressed it.
cc @n3nash |
hudi-test-suite/README.md
Outdated
## Entry class to the test suite | ||
|
||
``` | ||
org.apache.hudi.bench.job.HudiTestSuiteJob.java - Entry Point of the hudi test suite job. This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to change the package name here, like remove "bench"
hudi-test-suite/README.md
Outdated
|
||
## Configurations required to run the job | ||
``` | ||
org.apache.hudi.bench.job.HudiTestSuiteConfig - Config class that drives the behavior of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same, I would also re-check if the names of the classes are the same..
hudi-test-suite/README.md
Outdated
[INFO] hudi-spark ......................................... SUCCESS [ 34.499 s] | ||
[INFO] hudi-utilities ..................................... SUCCESS [ 8.626 s] | ||
[INFO] hudi-cli ........................................... SUCCESS [ 14.921 s] | ||
[INFO] hudi-bench ......................................... SUCCESS [ 7.706 s] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might have to re-run and update this with the new package name..
# COPY_ON_WRITE tables | ||
========================= | ||
## Run the following command to start the test suite | ||
spark-submit \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please start your docker and try to run both these commands after renaming and package changes to make sure they run fine..
@yanghua Left some comments |
@n3nash Have done renaming work. Please have another look. |
@yanghua looks good, did you try running it in docker ? Also, can you squash your commits and then I can merge this PR ? |
Absolutely, I can squash the commits. Sorry, I did not verify those commands in the docker. My local docker env always has some problems. Can you help to verify them? |
3dc85eb
to
0456214
Compare
I verified them, looks ok, please fix the build and I can merge this. |
OK, The Travis failure is due to the upgrade of the Spark dependencies. I have rebased the test suite branch. I am trying to figure it out. |
@yanghua were you able to fix the build ? |
@yanghua no worries, happy new year! please take a look at this once you're back from the new year holiday |
I guess once you rebase this, the build should get fixed (merged your spark upgrade pr) |
Yes, will rebase this PR and let Travis recheck it again. |
…the test suite module
…the test suite module (apache#1191)
…the test suite module (#1191)
…the test suite module (#1191)
What is the purpose of the pull request
Add hudi test suite documentation into the README file of the test suite module
Brief change log
Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.