Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-397] Normalize log print statement #1220

Closed

Conversation

wangxianghu
Copy link
Contributor

What is the purpose of the pull request

Redo hudi-test-suite log statements using SLF4J
Normalize log print statement

Brief change log

Redo hudi-test-suite log statements using SLF4J
Normalize log print statement

Verify this pull request

This pull request should be covered by existing tests.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hmatu
Copy link
Contributor

hmatu commented Jan 13, 2020

If you modify some changes, you can continue to commit to same branch, no need to create a new pr, like #1219 #1217

@hmatu
Copy link
Contributor

hmatu commented Jan 13, 2020

Please use git config --list to check whether your email is right or not.

@n3nash n3nash self-requested a review January 13, 2020 18:31
@n3nash n3nash self-assigned this Jan 13, 2020
@n3nash
Copy link
Contributor

n3nash commented Jan 13, 2020

@wangxianghu Thanks for the PR, does this exhaustively take care of all the logs in the test-suite module ?

@wangxianghu
Copy link
Contributor Author

Hi @hmatu, Thanks for your advice, I will pay attention next time.

@wangxianghu
Copy link
Contributor Author

Hi @n3nash, This PR covered all the logs in test-suite module. Besides, I found the wrong email was used. I will fix it.

@hmatu
Copy link
Contributor

hmatu commented Jan 14, 2020

Close again?

@wangxianghu
Copy link
Contributor Author

@hmatu Roll back, It closed automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants