-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-562] Added a few test cases for class org.apache.hudi.WriteStatus #1285
Conversation
@prashantwason The Travis is red, please recheck your change and the failure reason. |
The failure is in hudi-integ-test which seems unrelated to my change. I will investigate the cause. |
Travis is green. |
@prashantwason I restarted the Travis build. It seemed like some transient issue with pulling the spark-avro package. Can you kick the travis again for other PR as well? |
Thanks @bhasudha I don't have write access so I cannot start travis rebuild. |
Re-trigger Travis does not need to have write access to the repository. You can use this command:
to commit an empty commit, then push the commit. The Travis will work again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @prashantwason thanks for your contribution. IMHO, we do not need to test a pure getter/setter method. I left some comments.
The motivation here is to bring the code-coverage up to 100% (where possible). At present, most files have coverage < 100% and a simple look at the coverage report does not show if:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prashantwason PTAL of the comments
Nothing much to change here then. org.apache.hudi.WriteStatus is already at a good test coverage. |
What is the purpose of the pull request
Added a few test cases for class org.apache.hudi.WriteStatus
Verify this pull request
This change added tests and can be verified as follows:
mvn test --also-make -DfailIfNoTests=false -Dtest=TestWriteStatus -pl hudi-client
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.