Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-562] Added a few test cases for class org.apache.hudi.WriteStatus #1285

Closed
wants to merge 1 commit into from

Conversation

prashantwason
Copy link
Member

@prashantwason prashantwason commented Jan 27, 2020

What is the purpose of the pull request

Added a few test cases for class org.apache.hudi.WriteStatus

Verify this pull request

This change added tests and can be verified as follows:

mvn test --also-make -DfailIfNoTests=false -Dtest=TestWriteStatus -pl hudi-client

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@yanghua
Copy link
Contributor

yanghua commented Jan 28, 2020

@prashantwason The Travis is red, please recheck your change and the failure reason.

@prashantwason
Copy link
Member Author

The failure is in hudi-integ-test which seems unrelated to my change. I will investigate the cause.

@prashantwason
Copy link
Member Author

Travis is green.

@bhasudha
Copy link
Contributor

Travis is green.

@prashantwason I restarted the Travis build. It seemed like some transient issue with pulling the spark-avro package. Can you kick the travis again for other PR as well?

@prashantwason
Copy link
Member Author

Thanks @bhasudha

I don't have write access so I cannot start travis rebuild.

@yanghua
Copy link
Contributor

yanghua commented Jan 29, 2020

Thanks @bhasudha

I don't have write access so I cannot start travis rebuild.

Re-trigger Travis does not need to have write access to the repository. You can use this command:

git commit --allow-empty -m 'trigger Travis rebuild'

to commit an empty commit, then push the commit. The Travis will work again.

Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prashantwason thanks for your contribution. IMHO, we do not need to test a pure getter/setter method. I left some comments.

@yanghua yanghua self-assigned this Jan 29, 2020
@prashantwason
Copy link
Member Author

prashantwason commented Jan 29, 2020

IMHO, we do not need to test a pure getter/setter method. I left some comments.

The motivation here is to bring the code-coverage up to 100% (where possible). At present, most files have coverage < 100% and a simple look at the coverage report does not show if:

  1. The coverage is less due to these getters/setters missing coverage, or
  2. There is actual code logic that is missing coverage.

Copy link
Contributor

@n3nash n3nash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prashantwason PTAL of the comments

@n3nash n3nash self-assigned this Jan 29, 2020
@prashantwason
Copy link
Member Author

Nothing much to change here then. org.apache.hudi.WriteStatus is already at a good test coverage.

@prashantwason prashantwason deleted the pw-HUDI-562 branch September 4, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants