[HUDI-566] Added new test cases for class HoodieTimeline, HoodieDefaultTimeline and HoodieActiveTimeline. #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3nash
reviewed
Jan 29, 2020
n3nash
reviewed
Jan 29, 2020
n3nash
reviewed
Jan 29, 2020
hudi-common/src/test/java/org/apache/hudi/common/table/string/TestHoodieActiveTimeline.java
Show resolved
Hide resolved
n3nash
reviewed
Jan 29, 2020
hudi-common/src/test/java/org/apache/hudi/common/table/string/TestHoodieActiveTimeline.java
Outdated
Show resolved
Hide resolved
n3nash
reviewed
Jan 29, 2020
hudi-common/src/test/java/org/apache/hudi/common/table/string/TestHoodieActiveTimeline.java
Outdated
Show resolved
Hide resolved
n3nash
reviewed
Jan 29, 2020
hudi-common/src/test/java/org/apache/hudi/common/table/string/TestHoodieActiveTimeline.java
Show resolved
Hide resolved
n3nash
reviewed
Jan 29, 2020
hudi-common/src/test/java/org/apache/hudi/common/table/string/TestHoodieActiveTimeline.java
Outdated
Show resolved
Hide resolved
n3nash
reviewed
Jan 29, 2020
hudi-common/src/test/java/org/apache/hudi/common/table/string/TestHoodieActiveTimeline.java
Show resolved
Hide resolved
n3nash
reviewed
Jan 29, 2020
hudi-common/src/test/java/org/apache/hudi/common/table/string/TestHoodieActiveTimeline.java
Outdated
Show resolved
Hide resolved
n3nash
reviewed
Jan 29, 2020
hudi-common/src/test/java/org/apache/hudi/common/table/string/TestHoodieActiveTimeline.java
Outdated
Show resolved
Hide resolved
n3nash
reviewed
Jan 29, 2020
n3nash
reviewed
Feb 4, 2020
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTimeline.java
Outdated
Show resolved
Hide resolved
n3nash
reviewed
Feb 4, 2020
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTimeline.java
Outdated
Show resolved
Hide resolved
n3nash
reviewed
Feb 4, 2020
n3nash
reviewed
Feb 4, 2020
hudi-common/src/test/java/org/apache/hudi/common/table/string/TestHoodieActiveTimeline.java
Outdated
Show resolved
Hide resolved
n3nash
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
@prashantwason Lgtm, 2 minor comments, once you address them please add a comment here and I will merge this PR
|
I have addressed all the comments. |
…ltTimeline and HoodieActiveTimeline.
prashantwason
force-pushed
the
pw-HUDI-566
branch
from
122edbd
to
952391d
Compare
|
Pushed a merged commit. The test which failed on travis (some timeout) succeeds on my local setup. Hopefully it was a transient error and works this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Added new test cases for class HoodieTimeline, HoodieDefaultTimeline and HoodieActiveTimeline.
Verify this pull request
This change added tests and can be verified as follows:
mvn test --also-make -DfailIfNoTests=false -Dtest=TestHoodieActiveTimeline -pl hudi-common
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.