Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-542] Introduce a new pom module named hudi-writer-common #1314

Merged
merged 1 commit into from Feb 8, 2020

Conversation

yanghua
Copy link
Contributor

@yanghua yanghua commented Feb 8, 2020

What is the purpose of the pull request

This pull request introduces a new pom module named hudi-writer-common

Brief change log

  • Introduce a new pom module named hudi-writer-common

Verify this pull request

This pull request is a trivial rework / code cleanup without any test coverage.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@yanghua
Copy link
Contributor Author

yanghua commented Feb 8, 2020

@vinothchandar @leesf FYI: new module hudi-writer-common on restructure-hudi-client.

@yanghua yanghua merged commit e7b1961 into apache:restructure-hudi-client Feb 8, 2020
@vinothchandar
Copy link
Member

@yanghua ack. Do we need a feature branch for this work? can't we do this on master with incremental commits

@yanghua
Copy link
Contributor Author

yanghua commented Feb 10, 2020

@yanghua ack. Do we need a feature branch for this work? can't we do this on master with incremental commits

A new module will be added here. If we copy related class files from hudi-client to the new module instead of moving those class files. it can theoretically be completed on the master branch

However, as a relatively large work (we will eventually move some classes in the hubi-client to other modules), it will be more reasonable to verify it on an independent branch to see whether those PRs can pass then migrate them to the master branch, which will not affect the master branch.

@vinothchandar
Copy link
Member

@yanghua as I also mentioned on the JIRA. What you suggest makes sense when we are in the phase of separating hudi-spark and hudi-writer-common.. This model also makes for us to take the hit of rebasing, without thrashing all existing PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants