[HUDI-571] CLI - add option to print additional commit metadata #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3nash
reviewed
Feb 12, 2020
|
|
||
| TableHeader header = new TableHeader().addTableHeaderField("action").addTableHeaderField("instant") | ||
| .addTableHeaderField("partition").addTableHeaderField("file_id").addTableHeaderField("prev_instant") | ||
| .addTableHeaderField("num_writes").addTableHeaderField("num_inserts").addTableHeaderField("num_deletes") |
There was a problem hiding this comment.
Do we add names in snake_case in other header commands ?
There was a problem hiding this comment.
Good point. converted to camel case to be consistent
satishkotha
force-pushed
the
sk/archFile
branch
from
ee77e08
to
a3b90de
Compare
|
@n3nash addressed comments. Please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Following up from debugging session last week to print additional metadata for commits. Additional metadata includes partition paths, fileIds, sizes etc
Note that this is added for both active and archived commits. The command line flag added (--includeExtraMetadata is similar to what we used for compactions)
Brief change log
Add includeExtraMetadata for CLI commands to list commits
Verify this pull request
->commits show --includeExtraMetadata true
╔═════════════╤════════════════╤════════════╤══════════════════════════════════════╤════════════════╤════════════╤═════════════╤═════════════╤═══════════════════╤════════════════════╤══════════════════╤══════════════════════════╤═══════════════════════╤═══════════════════╤═════════════════════════════════╤═══════════════════╗
║ action │ instant │ partition │ file_id │ prev_instant │ num_writes │ num_inserts │ num_deletes │ num_update_writes │ total_write_errors │ total_log_blocks │ total_corrupt_log_blocks │ total_rollback_blocks │ total_log_records │ total_updated_records_compacted │ total_write_bytes ║
╠═════════════╪════════════════╪════════════╪══════════════════════════════════════╪════════════════╪════════════╪═════════════╪═════════════╪═══════════════════╪════════════════════╪══════════════════╪══════════════════════════╪═══════════════════════╪═══════════════════╪═════════════════════════════════╪═══════════════════╣
║ deltacommit │ 20200210180215 │ null │ da59f86c-c1ac-4f32-bce7-f97b6a3fb35e │ 20200210010321 │ 2 │ 0 │ 0 │ 0 │ 0 │ 0 │ 0 │ 0 │ 0 │ 0 │ 28128 ║
╟─────────────┼────────────────┼────────────┼──────────────────────────────────────┼────────────────┼────────────┼─────────────┼─────────────┼───────────────────┼────────────────────┼──────────────────┼──────────────────────────┼───────────────────────┼───────────────────┼─────────────────────────────────┼────────
->commits show
║ CommitTime │ Total Bytes Written │ Total Files Added │ Total Files Updated │ Total Partitions Written │ Total Records Written │ Total Update Records Written │ Total Errors ║
╠════════════════╪═════════════════════╪═══════════════════╪═════════════════════╪══════════════════════════╪═══════════════════════╪══════════════════════════════╪══════════════╣
║ 20200210180215 │ 886.8 MB │ 0 │ 1681 │ 276 │ 1535368 │ 18183 │ 0 ║
╟────────────────┼─────────────────────┼───────────────────┼─────────────────────┼──────────────────────────┼───────────────────────┼──────────────────────────────┼──────────────╢
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.