[HUDI-748] Adding .codecov.yml to set exclusions for code coverage reports. #1468
Conversation
There was a problem hiding this comment.
We do enforce the testing ... A lot of this is due experimental code that has become more used..
I know we can change this later. but I fear if we suppress now, it will be forgotten.. There are some good candidateshere.. but I would like to file JIRAs for some of the core classes in utilities and see if we can fix it, rather than masking..
@bvaradar could you please look each file case by case and only leave ones that have very low value in testing (migration code, etc)
.codecov.yml
Outdated
| - "hudi-common/src/main/java/org/apache/hudi/avro/model/*" | ||
| - "hudi-common/src/main/java/org/apache/hudi/common/model/*" | ||
| - "hudi-common/src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java" | ||
| - "hudi-common/src/main/java/org/apache/hudi/common/table/timeline/dto/*" |
There was a problem hiding this comment.
@bvaradar do you see these needing unit tests in the future.
There was a problem hiding this comment.
@prashantwason : Can we retain DTO classes. It has translation functions and I caught an issue there as part of PR-1459. As part of TestRemoteHoodieTableFileSystemView, these classes should be anyway covered. Can we retain these classes.
|
@prashantwason I am going to let @bvaradar make the final call here |
.codecov.yml
Outdated
| - "hudi-common/src/main/java/org/apache/hudi/avro/model/*" | ||
| - "hudi-common/src/main/java/org/apache/hudi/common/model/*" | ||
| - "hudi-common/src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java" | ||
| - "hudi-common/src/main/java/org/apache/hudi/common/table/timeline/dto/*" |
There was a problem hiding this comment.
@prashantwason : Can we retain DTO classes. It has translation functions and I caught an issue there as part of PR-1459. As part of TestRemoteHoodieTableFileSystemView, these classes should be anyway covered. Can we retain these classes.
|
I have removed the following form the exclusions as requested. Please take a look again. hudi-common/src/main/java/org/apache/hudi/common/model/* |
What is the purpose of the pull request
Adding some exclusions for code coverage reports.
Brief change log
Added a .codecov.yml file which has entries for java classes which will be excluded when generating code coverage reports.
Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.