[HUDI-757] Added hudi-cli command to export metadata of Instants. #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3nash
reviewed
Apr 1, 2020
hudi-cli/src/main/java/org/apache/hudi/cli/commands/ExportCommand.java
Outdated
Show resolved
Hide resolved
n3nash
reviewed
Apr 1, 2020
hudi-cli/src/main/java/org/apache/hudi/cli/commands/ExportCommand.java
Outdated
Show resolved
Hide resolved
n3nash
reviewed
Apr 1, 2020
|
I have addressed all you review comments. |
|
Currently the export writes out binary avro records for instants read from the metadata archive files. This beats the purpose of exporting for debugging. I am updating the code to write out json formatted records instead for all exported instants. |
prashantwason
force-pushed
the
HUDI-757
branch
2 times, most recently
from
63d8c1f
to
1405db4
Compare
|
Updated to write out instant metadata in json format so its easy to use CLI tools. Tested using a few HUDI datasets and works good. |
|
CI actually passed.. when I click on the link.. may be kick the job again by making an empty commit/amend |
prashantwason
force-pushed
the
HUDI-757
branch
2 times, most recently
from
7279117
to
0e94b76
Compare
|
Fixed the merge conflict and pushed again. |
lamberken
reviewed
Apr 15, 2020
hudi-cli/src/main/java/org/apache/hudi/cli/commands/ExportCommand.java
Outdated
Show resolved
Hide resolved
lamberken
reviewed
Apr 15, 2020
hudi-cli/src/main/java/org/apache/hudi/cli/commands/ExportCommand.java
Outdated
Show resolved
Hide resolved
Example: hudi:db.table-> export instants --localFolder /tmp/ --limit 5 --actions clean,rollback,commit --desc false
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Added hudi-cli command to export metadata of Instants.
Brief change log
Added a new command to hudi-cli
Verify this pull request
This change can be verified by running hudi-cli, connecting to a HUDI table and running the following command:
hudi:db.table-> export instants --localFolder /tmp/dump --limit 5 --actions clean,rollback,commit --desc false
After this, 5 instant files should have been created in the /tmp/dump folder.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.