[HUDI-798] Migrate to Mockito Jupiter for JUnit 5 #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
xushiyan
commented
Apr 16, 2020
There was a problem hiding this comment.
@yanghua @vinothchandar Please kindly review this to enable Junit 5 adoption for other PRs. 🙏
Comment on lines
-73
to
+72
| import static org.mockito.Matchers.anyObject; | ||
| import static org.mockito.ArgumentMatchers.any; |
There was a problem hiding this comment.
anyObject is deprecated... any is the alias
Comment on lines
-89
to
+81
| doNothing().when(out).writeByte(anyByte()); | ||
| doNothing().when(out).writeByte(anyInt()); |
There was a problem hiding this comment.
writeByte() actually takes an int.. so strict stubbing requires an int for this.
Comment on lines
-143
to
+135
| byte[] bytes = invocation.getArgumentAt(0, byte[].class); | ||
| byte[] bytes = invocation.getArgument(0); |
There was a problem hiding this comment.
the new API refers getArgument()
https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/invocation/InvocationOnMock.html#getArgument-int-
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.