Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-814] Migrate hudi-client tests to JUnit 5 #1570

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

xushiyan
Copy link
Member

@xushiyan xushiyan commented Apr 29, 2020

Migrate the test cases in hudi-client to JUnit 5.

Follows #1553

Migration status (after merging)

Package JUnit 5 lib API migration Restructure packages
hudi-cli -
hudi-client -
hudi-common 🚧 🚧
hudi-hadoop-mr -
hudi-hive-sync -
hudi-integ-test N.A.
hudi-spark -
hudi-timeline-service -
hudi-utilities 🚧 -

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@xushiyan
Copy link
Member Author

@yanghua This PR migrates all remaining test cases in hudi-client that are not subclasses of HoodieClientTestHarness. It is ready for review.

@yanghua yanghua self-requested a review April 29, 2020 05:45
@yanghua yanghua self-assigned this Apr 29, 2020
Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xushiyan thanks for your contribution. LGTM.

@yanghua yanghua merged commit 69b1630 into apache:master Apr 29, 2020
@xushiyan xushiyan deleted the migrate-hudi-client-tests branch April 29, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants