Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Fix apache-rat violations #1639

Merged
merged 2 commits into from
May 18, 2020
Merged

Conversation

jfrazee
Copy link
Member

@jfrazee jfrazee commented May 17, 2020

This fixes a few apache-rat violations and adds exclusions for the GitHub PR template type stuff. Note there is already a general attribution for Twitter in the NOTICE so I don't think we need to add another.

 hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java
 hudi-utilities/src/main/java/org/apache/hudi/utilities/exception/HoodieSnapshotExporterException.java
 hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestInputBatch.java
.github/**

@codecov-io
Copy link

codecov-io commented May 17, 2020

Codecov Report

Merging #1639 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1639      +/-   ##
============================================
+ Coverage     16.71%   16.72%   +0.01%     
- Complexity      795      796       +1     
============================================
  Files           340      340              
  Lines         15030    15030              
  Branches       1499     1499              
============================================
+ Hits           2512     2514       +2     
+ Misses        12188    12186       -2     
  Partials        330      330              
Impacted Files Coverage Δ Complexity Δ
.../apache/hudi/common/util/ObjectSizeCalculator.java 77.61% <ø> (ø) 25.00 <0.00> (ø)
...apache/hudi/common/fs/HoodieWrapperFileSystem.java 22.69% <0.00%> (+0.70%) 29.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a0080...b50fc84. Read the comment docs.

Copy link
Contributor

@bvaradar bvaradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jfrazee for fixing the rat violations. I looked around old emails and previous PRs which brought this change. I think it is enough to just mention the attribution in NOTICE file.

@bvaradar
Copy link
Contributor

For the other classes, the underlying problem is that apache-rat was not enabled for hudi-utilities bundle

@bvaradar
Copy link
Contributor

@jfrazee : Thanks a lot for your help in identifying and providing the fix. There is one more related change as part of this and I took the liberty to add the patch to this PR. If the tests goes fine, I will merge the combined changes.

@vinothchandar
Copy link
Member

@bvaradar hudi-integ-test also does not list the rat plugin.. Might be good to add these to bundles as well, just in case. (our release script will catch all this.. however good to do upfront)

Copy link
Member

@smarthi smarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge

@bvaradar
Copy link
Contributor

@vinothchandar : Added rat check to hudi-integ-test.

@bvaradar bvaradar merged commit 2600d2d into apache:master May 18, 2020
nsivabalan pushed a commit that referenced this pull request Jun 1, 2020
* MINOR Fix apache-rat violations. Also, enabling RAT for hudi-utilities and hudi-integ-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants