[HUDI-707]Add unit test for StatsCommand #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hddong
force-pushed
the
add-test-StatsCommand
branch
from
b27c8b0
to
56f3de2
Compare
Yes, of course. |
Codecov Report
@@ Coverage Diff @@
## master #1645 +/- ##
=========================================
Coverage 18.33% 18.33%
Complexity 855 855
=========================================
Files 344 344
Lines 15167 15167
Branches 1512 1512
=========================================
Hits 2781 2781
Misses 12033 12033
Partials 353 353 Continue to review full report at Codecov.
|
hddong
force-pushed
the
add-test-StatsCommand
branch
from
138f2f8
to
a33b560
Compare
|
@yanghua : it's ready now. |
yanghua
reviewed
May 21, 2020
| @@ -64,8 +64,9 @@ public void init() throws IOException { | |||
| tablePath = basePath + File.separator + tableName; | |||
|
|
|||
| // Create table and connect | |||
| System.out.println(tablePath); | |||
There was a problem hiding this comment.
Can we remove stdout print?
| @Test | ||
| public void testWriteAmplificationStats() { | ||
| // generate data and metadata | ||
| Map<String, Integer[]> data = new LinkedHashMap(); |
There was a problem hiding this comment.
-> Map<String, Integer[]> data = new LinkedHashMap<>();
| public void testFileSizeStats() throws IOException { | ||
| String commit1 = "100"; | ||
| String commit2 = "101"; | ||
| Map<String, Integer[]> data = new LinkedHashMap(); |
| return HoodiePrintHelper.print(header, getFieldNameToConverterMap(), sortByField, descending, limit, headerOnly, rows); | ||
| } | ||
|
|
||
| public Map getFieldNameToConverterMap() { |
There was a problem hiding this comment.
Can we return a generic type Map<String, Function<Object, String>>?
|
@yanghua Thanks for your review, had address them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
Add unit test for StatsCommand
Brief change log
Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.