[HUDI-273] Translate the Writing Data page into Chinese documentation #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leesf
reviewed
Oct 16, 2019
leesf
reviewed
Oct 16, 2019
leesf
reviewed
Oct 16, 2019
leesf
reviewed
Oct 16, 2019
leesf
reviewed
Oct 16, 2019
|
Thanks for opening the PR @yihua . The changes look good overall. Only left some minor comments. |
|
@leesf Thanks for your meticulous review. I addressed your comments in my latest commit. |
leesf
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Thanks for addressing my comments @yihua . LGTM.
Now please merge this PR when you have time. @vinothchandar Thanks.
yihua
force-pushed
the
HUDI-273-translate-writing-data
branch
from
1c74533
to
49356e1
Compare
|
@vinothchandar this PR is ready to be merged. |
yihua
force-pushed
the
HUDI-273-translate-writing-data
branch
from
49356e1
to
1b70162
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HUDI-273