New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove withPartitionPath from the public API #507
Comments
@aokolnychyi, @prodeezy, what do you think about this issue and possibly targeting this for the release? |
We used that only for importing existing tables to Iceberg. We have tests but I haven't seen a real use case that required it. |
Yeah, for importing, I'm wondering if we shouldn't require going through an import API call, like the one in |
That would work for us. We developed our version of migration before we had it in |
We unfortunately depend on this currently but we will work on taking this dependency out. |
@prodeezy, we'll leave it in for now. Just let us know when you've moved away from it. |
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible. |
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' |
Several issues (#428, #505) have been opened where people are using
DataFiles.Builder#withPartitionPath
to parse partition key strings. This is an anti-pattern and Iceberg should not support serialization to and from string. Conversion to a partition key is a one-way conversion.Having the
withPartitionPath
method in the public API encourages using this anti-pattern. I think we should remove it.The text was updated successfully, but these errors were encountered: