Refactor FilteredManifest and ManifestGroup #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
reviewed
Jan 17, 2020
rdblue
reviewed
Jan 17, 2020
rdblue
reviewed
Jan 17, 2020
rdsr
force-pushed
the
refactor_filtered_manifest
branch
from
d8627c9
to
e36373a
Compare
|
Thanks for the review @rdblue! . I addressed your comments! |
rdsr
force-pushed
the
refactor_filtered_manifest
branch
from
e36373a
to
4f8d017
Compare
|
Any thoughts on the updated PR @rdblue ? |
rdblue
reviewed
Jan 23, 2020
rdblue
reviewed
Jan 23, 2020
rdblue
reviewed
Jan 23, 2020
rdblue
reviewed
Jan 23, 2020
|
@rdsr, thanks for the update! I think it's close, but we need to still avoid a copy. Also, I think there is a better way to update |
rdsr
force-pushed
the
refactor_filtered_manifest
branch
from
6e70203
to
dd34f48
Compare
|
Thanks @rdsr! Just one remaining issue with the stats column projection and I think we're ready to get this in. |
rdsr
commented
Jan 24, 2020
rdblue
reviewed
Jan 27, 2020
| } | ||
|
|
||
| /** | ||
| * @return an Iterator of DataFile. Makes defensive copies of files before returning |
rdblue
reviewed
Jan 27, 2020
rdblue
reviewed
Jan 27, 2020
| // Make sure we have all stats columns for metrics evaluator | ||
| return rowFilter != Expressions.alwaysTrue() && | ||
| !columns.containsAll(ManifestReader.ALL_COLUMNS) && | ||
| !columns.containsAll(STATS_COLUMNS); |
There was a problem hiding this comment.
I like how straight-forward this is now.
|
@rdsr, looks good to me! I'll wait until tests pass and merge it. Thanks for the quick update! |
rdblue
pushed a commit
to rdblue/iceberg
that referenced
this pull request
Apr 20, 2020
rdblue
pushed a commit
to rdblue/iceberg
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
liveEntries()anditerator()are now sharing underlying codeallEntries()orliveEntries()oriterator()1. ManifestGroup now relies on a builderallEntries(),liveEntries()anditerator()does not reuse containers and creates a copy. If this is too expensive in some case we can have a option toreuseContainersThese changes will affect #315 as well
Update
allEntries()orliveEntries()oriterator()if required for metrics evaluationallEntries(),liveEntries()do not create copies of entries whereasiterator()does