Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-416][Sort] Alter Sort example doc #417

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

GanfengTan
Copy link
Contributor

Fixes #416

The addition of the new Sort feature requires modifications to the example.

Motivation

The previous example is incomplete and needs to be modified.

Modifications

Added easy-to-understand examples.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

docs/modules/sort/datastream_example.md Outdated Show resolved Hide resolved
docs/modules/sort/datastream_example.md Show resolved Hide resolved
docs/modules/sort/datastream_example.md Outdated Show resolved Hide resolved
docs/modules/sort/datastream_example.md Outdated Show resolved Hide resolved
docs/modules/sort/datastream_example.md Outdated Show resolved Hide resolved
docs/modules/sort/datastream_example.md Outdated Show resolved Hide resolved
docs/modules/sort/datastream_example.md Outdated Show resolved Hide resolved
@dockerzhang dockerzhang merged commit f0ba3ef into apache:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sort] Alter Sort example doc
3 participants